Commit 286ed198 authored by Diederik de Haas's avatar Diederik de Haas Committed by Manivannan Sadhasivam
Browse files

PCI: dw-rockchip: Fix PHY function call sequence in rockchip_pcie_phy_deinit() 



The documentation for the phy_power_off() function explicitly says that it
must be called before phy_exit().

Hence, follow the same rule in rockchip_pcie_phy_deinit().

Fixes: 0e898eb8 ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")
Signed-off-by: default avatarDiederik de Haas <didi.debian@cknow.org>
[mani: commit message change]
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarDragan Simic <dsimic@manjaro.org>
Acked-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Cc: stable@vger.kernel.org	# v5.15+
Link: https://patch.msgid.link/20250417142138.1377451-1-didi.debian@cknow.org
parent 5e5a3bf4

drivers/pci/controller/dwc/pcie-dw-rockchip.c

+1 −1
Original line number Diff line number Diff line
@@ -431,8 +431,8 @@ static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip) 


static void rockchip_pcie_phy_deinit(struct rockchip_pcie *rockchip)

{

	phy_exit(rockchip->phy);

	phy_power_off(rockchip->phy);

	phy_exit(rockchip->phy);

}



static const struct dw_pcie_ops dw_pcie_ops = {