Commit 28753212 authored by Benno Lossin's avatar Benno Lossin Committed by Miguel Ojeda
Browse files

rust: types: remove `Either<L, R>` 



This enum is not used. Additionally, using it would result in poor
ergonomics, because in order to do any operation on a value it has to be
matched first. Our version of `Either` also doesn't provide any helper
methods making it even more difficult to use.

The alternative of creating a custom enum for the concrete use-case also
is much better for ergonomics. As one can provide functions on the type
directly and users don't need to match the value manually.

Signed-off-by: default avatarBenno Lossin <lossin@kernel.org>
Reviewed-by: default avatarDanilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20250519124304.79237-1-lossin@kernel.org


Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 15235902

rust/kernel/types.rs

+0 −18
Original line number Diff line number Diff line
@@ -569,24 +569,6 @@ fn drop(&mut self) { 
    }

}



/// A sum type that always holds either a value of type `L` or `R`.

///

/// # Examples

///

/// ```

/// use kernel::types::Either;

///

/// let left_value: Either<i32, &str> = Either::Left(7);

/// let right_value: Either<i32, &str> = Either::Right("right value");

/// ```

pub enum Either<L, R> {

    /// Constructs an instance of [`Either`] containing a value of type `L`.

    Left(L),



    /// Constructs an instance of [`Either`] containing a value of type `R`.

    Right(R),

}



/// Zero-sized type to mark types not [`Send`].

///

/// Add this type as a field to your struct if your type should not be sent to a different task.