Commit 288ff0d1 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Keith Busch
Browse files

nvme-pci: skip nvme_write_sq_db on empty rqlist 



nvme_submit_cmds() should check the rqlist before calling
nvme_write_sq_db(); if the list is empty, it must return immediately.

Fixes: beadf008 ("nvme-pci: reverse request order in nvme_queue_rqs")
Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 32c92814

drivers/nvme/host/pci.c

+3 −0
Original line number Diff line number Diff line
@@ -986,6 +986,9 @@ static void nvme_submit_cmds(struct nvme_queue *nvmeq, struct rq_list *rqlist) 
{

	struct request *req;



	if (rq_list_empty(rqlist))

		return;



	spin_lock(&nvmeq->sq_lock);

	while ((req = rq_list_pop(rqlist))) {

		struct nvme_iod *iod = blk_mq_rq_to_pdu(req);