Commit 289088d5 authored by Miguel Ojeda's avatar Miguel Ojeda
Browse files

rust: module: add static pointer to `{init,cleanup}_module()` 



Add the equivalent of the `___ADDRESSABLE()` annotation in the
`module_{init,exit}` macros to the Rust `module!` macro.

Without this, `objtool` would complain if enabled for Rust (under IBT
builds), e.g.:

    samples/rust/rust_print.o: warning: objtool: cleanup_module(): not an indirect call target
    samples/rust/rust_print.o: warning: objtool: init_module(): not an indirect call target

Tested-by: default avatarAlice Ryhl <aliceryhl@google.com>
Tested-by: default avatarBenno Lossin <benno.lossin@proton.me>
Reviewed-by: default avatarGary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20240725183325.122827-2-ojeda@kernel.org


Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 87634653

rust/macros/module.rs

+12 −0
Original line number Diff line number Diff line
@@ -256,6 +256,12 @@ mod __module_init {{ 
                        unsafe {{ __init() }}

                    }}



                    #[cfg(MODULE)]

                    #[doc(hidden)]

                    #[used]

                    #[link_section = \".init.data\"]

                    static __UNIQUE_ID___addressable_init_module: unsafe extern \"C\" fn() -> i32 = init_module;



                    #[cfg(MODULE)]

                    #[doc(hidden)]

                    #[no_mangle]
@@ -269,6 +275,12 @@ mod __module_init {{ 
                        unsafe {{ __exit() }}

                    }}



                    #[cfg(MODULE)]

                    #[doc(hidden)]

                    #[used]

                    #[link_section = \".exit.data\"]

                    static __UNIQUE_ID___addressable_cleanup_module: extern \"C\" fn() = cleanup_module;



                    // Built-in modules are initialized through an initcall pointer

                    // and the identifiers need to be unique.

                    #[cfg(not(MODULE))]