Commit 28a84da7 authored by David Matlack's avatar David Matlack Committed by Alex Williamson
Browse files

vfio: selftests: Upgrade driver logging to dev_err() 



Upgrade various logging in the VFIO selftests drivers from dev_info() to
dev_err(). All of these logs indicate scenarios that may be unexpected.
For example, the logging during probing indicates matching devices but
that aren't supported by the driver. And the memcpy errors can indicate
a problem if the caller was not trying to do something like exercise I/O
fault handling. Exercising I/O fault handling is certainly a valid thing
to do, but the driver can't infer the caller's expectations, so better
to just log with dev_err().

Suggested-by: default avatarRaghavendra Rao Ananta <rananta@google.com>
Reviewed-by: default avatarAlex Mastro <amastro@fb.com>
Tested-by: default avatarAlex Mastro <amastro@fb.com>
Reviewed-by: default avatarRaghavendra Rao Ananta <rananta@google.com>
Signed-off-by: default avatarDavid Matlack <dmatlack@google.com>
Link: https://lore.kernel.org/r/20251126231733.3302983-10-dmatlack@google.com


Signed-off-by: default avatarAlex Williamson <alex@shazbot.org>
parent c4854544

tools/testing/selftests/vfio/lib/drivers/dsa/dsa.c

+2 −2
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ static int dsa_probe(struct vfio_pci_device *device) 
		return -EINVAL;



	if (dsa_int_handle_request_required(device)) {

		dev_info(device, "Device requires requesting interrupt handles\n");

		dev_err(device, "Device requires requesting interrupt handles\n");

		return -EINVAL;

	}
@@ -256,7 +256,7 @@ static int dsa_completion_wait(struct vfio_pci_device *device, 
	if (status == DSA_COMP_SUCCESS)

		return 0;



	dev_info(device, "Error detected during memcpy operation: 0x%x\n", status);

	dev_err(device, "Error detected during memcpy operation: 0x%x\n", status);

	return -1;

}

tools/testing/selftests/vfio/lib/drivers/ioat/ioat.c

+2 −2
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ static int ioat_probe(struct vfio_pci_device *device) 
		r = 0;

		break;

	default:

		dev_info(device, "ioat: Unsupported version: 0x%x\n", version);

		dev_err(device, "ioat: Unsupported version: 0x%x\n", version);

		r = -EINVAL;

	}

	return r;
@@ -135,7 +135,7 @@ static void ioat_handle_error(struct vfio_pci_device *device) 
{

	void *registers = ioat_channel_registers(device);



	dev_info(device, "Error detected during memcpy operation!\n"

	dev_err(device, "Error detected during memcpy operation!\n"

		 "  CHANERR: 0x%x\n"

		 "  CHANERR_INT: 0x%x\n"

		 "  DMAUNCERRSTS: 0x%x\n",