Commit 28ab9769 authored by Igor Pylypiv's avatar Igor Pylypiv Committed by Niklas Cassel
Browse files

ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error 



SAT-5 revision 8 specification removed the text about the ANSI INCITS
431-2007 compliance which was requiring SCSI/ATA Translation (SAT) to
return descriptor format sense data for the ATA PASS-THROUGH commands
regardless of the setting of the D_SENSE bit.

Let's honor the D_SENSE bit for ATA PASS-THROUGH commands while
generating the "ATA PASS-THROUGH INFORMATION AVAILABLE" sense data.

SAT-5 revision 7
================

12.2.2.8 Fixed format sense data

Table 212 shows the fields returned in the fixed format sense data
(see SPC-5) for ATA PASS-THROUGH commands. SATLs compliant with ANSI
INCITS 431-2007, SCSI/ATA Translation (SAT) return descriptor format
sense data for the ATA PASS-THROUGH commands regardless of the setting
of the D_SENSE bit.

SAT-5 revision 8
================

12.2.2.8 Fixed format sense data

Table 211 shows the fields returned in the fixed format sense data
(see SPC-5) for ATA PASS-THROUGH commands.

Cc: stable@vger.kernel.org # 4.19+
Reported-by: default avatarNiklas Cassel <cassel@kernel.org>
Closes: https://lore.kernel.org/linux-ide/Zn1WUhmLglM4iais@ryzen.lan


Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarIgor Pylypiv <ipylypiv@google.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20240702024735.1152293-4-ipylypiv@google.com


Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
parent 97981926

drivers/ata/libata-scsi.c

+2 −5
Original line number Diff line number Diff line
@@ -941,11 +941,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) 
				   &sense_key, &asc, &ascq);

		ata_scsi_set_sense(qc->dev, cmd, sense_key, asc, ascq);

	} else {

		/*

		 * ATA PASS-THROUGH INFORMATION AVAILABLE

		 * Always in descriptor format sense.

		 */

		scsi_build_sense(cmd, 1, RECOVERED_ERROR, 0, 0x1D);

		/* ATA PASS-THROUGH INFORMATION AVAILABLE */

		ata_scsi_set_sense(qc->dev, cmd, RECOVERED_ERROR, 0, 0x1D);

	}

}