Commit 28d19ec9 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jakub Kicinski
Browse files

net/mlx5e: flower: validate encapsulation control flags 



Encapsulation control flags are currently not used anywhere,
so all flags are currently unsupported by all drivers.

This patch adds validation of this assumption, so that
encapsulation flags may be used in the future.

In case any encapsulation control flags are masked,
flow_rule_match_has_enc_control_flags() sets a NL extended
error message, and we return -EOPNOTSUPP.

Only compile tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarDavide Caratti <dcaratti@redhat.com>
Link: https://lore.kernel.org/r/20240609173358.193178-4-ast@fiberby.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2ede54f8

drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c

+6 −0
Original line number Diff line number Diff line
@@ -850,6 +850,12 @@ int mlx5e_tc_tun_parse(struct net_device *filter_dev, 
		flow_rule_match_enc_control(rule, &match);

		addr_type = match.key->addr_type;



		if (flow_rule_has_enc_control_flags(match.mask->flags,

						    extack)) {

			err = -EOPNOTSUPP;

			goto out;

		}



		/* For tunnel addr_type used same key id`s as for non-tunnel */

		if (addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {

			struct flow_match_ipv4_addrs match;