Commit 28e09476 authored by Steve French's avatar Steve French
Browse files

smb3: fix Open files on server counter going negative 



We were decrementing the count of open files on server twice
for the case where we were closing cached directories.

Fixes: 8e843bf3 ("cifs: return a single-use cfid if we did not get a lease")
Cc: stable@vger.kernel.org
Acked-by: default avatarBharath SM <bharathsm@microsoft.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent ec4535b2

fs/smb/client/cached_dir.c

+2 −2
Original line number Diff line number Diff line
@@ -433,8 +433,8 @@ smb2_close_cached_fid(struct kref *ref) 
	if (cfid->is_open) {

		rc = SMB2_close(0, cfid->tcon, cfid->fid.persistent_fid,

			   cfid->fid.volatile_fid);

		if (rc != -EBUSY && rc != -EAGAIN)

			atomic_dec(&cfid->tcon->num_remote_opens);

		if (rc) /* should we retry on -EBUSY or -EAGAIN? */

			cifs_dbg(VFS, "close cached dir rc %d\n", rc);

	}



	free_cached_dir(cfid);