Commit 298c2af4 authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

drivers: core: fw_devlink: Make the error message a bit more useful 

It would make it easier to debugs issues similar to the ones
reported[1][2] recently where some devices didn't have the fwnode set.

[1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/
[2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/



Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20241024061347.1771063-4-saravanak@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 74ffe43b

drivers/base/core.c

+2 −2
Original line number Diff line number Diff line
@@ -2173,8 +2173,8 @@ static int fw_devlink_create_devlink(struct device *con, 
		}



		if (con != sup_dev && !device_link_add(con, sup_dev, flags)) {

			dev_err(con, "Failed to create device link (0x%x) with %s\n",

				flags, dev_name(sup_dev));

			dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n",

				flags, dev_name(sup_dev), link->consumer);

			ret = -EINVAL;

		}