Commit 29fa7f9e authored by Yury Norov (NVIDIA)'s avatar Yury Norov (NVIDIA) Committed by Paolo Abeni
Browse files

net: phy: nxp-c45-tja11xx: use bitmap_empty() where appropriate 



The driver opencodes bitmap_empty() in a couple of funcitons. Switch to
the proper and more verbose API.

Signed-off-by: default avatarYury Norov (NVIDIA) <yury.norov@gmail.com>
Link: https://patch.msgid.link/20250913182837.206800-1-yury.norov@gmail.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent dfc0882a

drivers/net/phy/nxp-c45-tja11xx-macsec.c

+2 −6
Original line number Diff line number Diff line
@@ -926,7 +926,6 @@ static int nxp_c45_mdo_dev_open(struct macsec_context *ctx) 
	struct phy_device *phydev = ctx->phydev;

	struct nxp_c45_phy *priv = phydev->priv;

	struct nxp_c45_secy *phy_secy;

	int any_bit_set;



	phy_secy = nxp_c45_find_secy(&priv->macsec->secy_list, ctx->secy->sci);

	if (IS_ERR(phy_secy))
@@ -939,8 +938,7 @@ static int nxp_c45_mdo_dev_open(struct macsec_context *ctx) 
	if (phy_secy->rx_sc)

		nxp_c45_rx_sc_en(phydev, phy_secy->rx_sc, true);



	any_bit_set = find_first_bit(priv->macsec->secy_bitmap, TX_SC_MAX);

	if (any_bit_set == TX_SC_MAX)

	if (bitmap_empty(priv->macsec->secy_bitmap, TX_SC_MAX))

		nxp_c45_macsec_en(phydev, true);



	set_bit(phy_secy->secy_id, priv->macsec->secy_bitmap);
@@ -953,7 +951,6 @@ static int nxp_c45_mdo_dev_stop(struct macsec_context *ctx) 
	struct phy_device *phydev = ctx->phydev;

	struct nxp_c45_phy *priv = phydev->priv;

	struct nxp_c45_secy *phy_secy;

	int any_bit_set;



	phy_secy = nxp_c45_find_secy(&priv->macsec->secy_list, ctx->secy->sci);

	if (IS_ERR(phy_secy))
@@ -967,8 +964,7 @@ static int nxp_c45_mdo_dev_stop(struct macsec_context *ctx) 
	nxp_c45_set_rx_sc0_impl(phydev, false);



	clear_bit(phy_secy->secy_id, priv->macsec->secy_bitmap);

	any_bit_set = find_first_bit(priv->macsec->secy_bitmap, TX_SC_MAX);

	if (any_bit_set == TX_SC_MAX)

	if (bitmap_empty(priv->macsec->secy_bitmap, TX_SC_MAX))

		nxp_c45_macsec_en(phydev, false);



	return 0;