Commit 2a293151 authored by Furong Xu's avatar Furong Xu Committed by Paolo Abeni
Browse files

net: stmmac: Optimize cache prefetch in RX path 



Current code prefetches cache lines for the received frame first, and
then dma_sync_single_for_cpu() against this frame, this is wrong.
Cache prefetch should be triggered after dma_sync_single_for_cpu().

This patch brings ~2.8% driver performance improvement in a TCP RX
throughput test with iPerf tool on a single isolated Cortex-A65 CPU
core, 2.84 Gbits/sec increased to 2.92 Gbits/sec.

Signed-off-by: default avatarFurong Xu <0x1207@gmail.com>
Reviewed-by: default avatarAlexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: default avatarYanteng Si <si.yanteng@linux.dev>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 2324c78a

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+1 −4
Original line number Diff line number Diff line
@@ -5508,10 +5508,6 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) 


		/* Buffer is good. Go on. */



		prefetch(page_address(buf->page) + buf->page_offset);

		if (buf->sec_page)

			prefetch(page_address(buf->sec_page));



		buf1_len = stmmac_rx_buf1_len(priv, p, status, len);

		len += buf1_len;

		buf2_len = stmmac_rx_buf2_len(priv, p, status, len);
@@ -5533,6 +5529,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) 


			dma_sync_single_for_cpu(priv->device, buf->addr,

						buf1_len, dma_dir);

			prefetch(page_address(buf->page) + buf->page_offset);



			xdp_init_buff(&ctx.xdp, buf_sz, &rx_q->xdp_rxq);

			xdp_prepare_buff(&ctx.xdp, page_address(buf->page),