Commit 2a2a04be authored by Johan Hovold's avatar Johan Hovold Committed by Chun-Kuang Hu
Browse files

drm/mediatek: Fix probe device leaks 



Make sure to drop the reference taken to each component device during
probe on probe failure (e.g. probe deferral) and on driver unbind.

Fixes: 6ea6f827 ("drm/mediatek: Use correct device pointer to get CMDQ client register")
Cc: stable@vger.kernel.org	# 5.12
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20250923152340.18234-4-johan@kernel.org/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 5e492005

drivers/gpu/drm/mediatek/mtk_ddp_comp.c

+11 −0
Original line number Diff line number Diff line
@@ -621,6 +621,13 @@ int mtk_find_possible_crtcs(struct drm_device *drm, struct device *dev) 
	return ret;

}



static void mtk_ddp_comp_put_device(void *_dev)

{

	struct device *dev = _dev;



	put_device(dev);

}



static void mtk_ddp_comp_clk_put(void *_clk)

{

	struct clk *clk = _clk;
@@ -656,6 +663,10 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, struct mtk_d 
	}

	comp->dev = &comp_pdev->dev;



	ret = devm_add_action_or_reset(dev, mtk_ddp_comp_put_device, comp->dev);

	if (ret)

		return ret;



	if (type == MTK_DISP_AAL ||

	    type == MTK_DISP_BLS ||

	    type == MTK_DISP_CCORR ||