Commit 2a2a7f5e authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf pmu: Avoid segv for missing name/alias_name in wildcarding 



The pmu name or alias_name fields may be NULL and should be skipped if
so. This is done in all loops of perf_pmu___name_match except the
final wildcard loop which was an oversight.

Fixes: 63e28713 ("perf pmu: Rename name matching for no suffix or wildcard variants")
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250527215035.187992-1-irogers@google.com


[ Fixup the Fixes: tag to the right commit ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4c046544

tools/perf/util/pmu.c

+3 −0
Original line number Diff line number Diff line
@@ -2143,6 +2143,9 @@ static bool perf_pmu___name_match(const struct perf_pmu *pmu, const char *to_mat 
	for (size_t i = 0; i < ARRAY_SIZE(names); i++) {

		const char *name = names[i];



		if (!name)

			continue;



		if (wildcard && perf_pmu__match_wildcard_uncore(name, to_match))

			return true;

		if (!wildcard && perf_pmu__match_ignoring_suffix_uncore(name, to_match))