Commit 2a330f16 authored by Avri Altman's avatar Avri Altman Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Remove redundant host_lock calls around UTRLCLR. 



There is no need to serialize single read/write calls to the host
controller registers. Remove the redundant host_lock calls that protect
access to the request list cLear register: UTRLCLR.

Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarAvri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20241024075033.562562-4-avri.altman@wdc.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5824e18b

drivers/ufs/core/ufshcd.c

+0 −3
Original line number Diff line number Diff line
@@ -3062,7 +3062,6 @@ bool ufshcd_cmd_inflight(struct scsi_cmnd *cmd) 
static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag)

{

	u32 mask;

	unsigned long flags;

	int err;



	if (hba->mcq_enabled) {
@@ -3082,9 +3081,7 @@ static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag) 
	mask = 1U << task_tag;



	/* clear outstanding transaction before retry */

	spin_lock_irqsave(hba->host->host_lock, flags);

	ufshcd_utrl_clear(hba, mask);

	spin_unlock_irqrestore(hba->host->host_lock, flags);



	/*

	 * wait for h/w to clear corresponding bit in door-bell.