Commit 2a743d94 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: remove constant variable and dead code 



g_wifi_on is always true. Remove the variable and the code that would
be run only if g_wifi_on was false.

While at it, remove a pointlesss comment that starts with /** and is
misinterpreted as a kernel-doc comment.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210419201126.25633-2-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8a24201f

drivers/staging/rtl8188eu/os_dep/rtw_android.c

+0 −17
Original line number Diff line number Diff line
@@ -52,16 +52,6 @@ struct android_wifi_priv_cmd { 
	int total_len;

};



/**

 * Local (static) functions and variables

 */



/* Initialize g_wifi_on to 1 so dhd_bus_start will be called for the first

 * time (only) in dhd_open, subsequential wifi on will be handled by

 * wl_android_wifi_on

 */

static int g_wifi_on = true;



int rtw_android_cmdstr_to_num(char *cmdstr)

{

	int cmd_num;
@@ -154,12 +144,6 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd) 
	case ANDROID_WIFI_CMD_SETFWPATH:

		goto response;

	}

	if (!g_wifi_on) {

		DBG_88E("%s: Ignore private cmd \"%s\" - iface %s is down\n",

			__func__, command, ifr->ifr_name);

		ret = 0;

		goto free;

	}

	switch (cmd_num) {

	case ANDROID_WIFI_CMD_STOP:

		break;
@@ -244,7 +228,6 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd) 
	} else {

		ret = bytes_written;

	}

free:

	kfree(command);

	return ret;

}