Unverified Commit 2a93192d authored by Niklas Cassel's avatar Niklas Cassel Committed by Krzysztof Wilczyński
Browse files

misc: pci_endpoint_test: Fix pci_endpoint_test_bars_read_bar() error handling 



Commit f26d37ee ("misc: pci_endpoint_test: Fix IOCTL return value")
changed the return value of pci_endpoint_test_bars_read_bar() from false
to -EINVAL on error, however, it failed to update the error handling.

Fixes: f26d37ee ("misc: pci_endpoint_test: Fix IOCTL return value")
Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20250204110640.570823-2-cassel@kernel.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
parent a28d2f23

drivers/misc/pci_endpoint_test.c

+2 −2
Original line number Diff line number Diff line
@@ -382,7 +382,7 @@ static int pci_endpoint_test_bars_read_bar(struct pci_endpoint_test *test, 
static int pci_endpoint_test_bars(struct pci_endpoint_test *test)

{

	enum pci_barno bar;

	bool ret;

	int ret;



	/* Write all BARs in order (without reading). */

	for (bar = 0; bar < PCI_STD_NUM_BARS; bar++)
@@ -398,7 +398,7 @@ static int pci_endpoint_test_bars(struct pci_endpoint_test *test) 
	for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {

		if (test->bar[bar]) {

			ret = pci_endpoint_test_bars_read_bar(test, bar);

			if (!ret)

			if (ret)

				return ret;

		}

	}