Commit 2aad93b6 authored by Bastien Curutchet's avatar Bastien Curutchet Committed by Lee Jones
Browse files

leds: pca9532: Remove irrelevant blink configuration error message 



The update_hw_blink() function prints an error message when hardware is
not able to handle a blink configuration on its own. IMHO, this isn't a
'real' error since the software fallback is used afterwards.

Remove the error messages to avoid flooding the logs with unnecessary
messages.

Cc: stable@vger.kernel.org
Fixes: 48ca7f30 ("leds: pca9532: Use PWM1 for hardware blinking")
Signed-off-by: default avatarBastien Curutchet <bastien.curutchet@bootlin.com>
Link: https://lore.kernel.org/r/20240826133237.134604-1-bastien.curutchet@bootlin.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 045391a0

drivers/leds/leds-pca9532.c

+2 −3
Original line number Diff line number Diff line
@@ -215,8 +215,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led, 
		if (other->state == PCA9532_PWM1) {

			if (other->ldev.blink_delay_on != delay_on ||

			    other->ldev.blink_delay_off != delay_off) {

				dev_err(&led->client->dev,

					"HW can handle only one blink configuration at a time\n");

				/* HW can handle only one blink configuration at a time */

				return -EINVAL;

			}

		}
@@ -224,7 +223,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led, 


	psc = ((delay_on + delay_off) * PCA9532_PWM_PERIOD_DIV - 1) / 1000;

	if (psc > U8_MAX) {

		dev_err(&led->client->dev, "Blink period too long to be handled by hardware\n");

		/* Blink period too long to be handled by hardware */

		return -EINVAL;

	}