Unverified Commit 2abf107d authored by Gabor Juhos's avatar Gabor Juhos Committed by Mark Brown
Browse files

spi: spi-qpic-snand: use CW_PER_PAGE_MASK bitmask 



Change the code to use the already defined CW_PER_PAGE_MASK
bitmask along with the FIELD_PREP() macro instead of using
magic values.

This makes the code more readable. It also syncs the affected
codes with their counterparts in the 'qcom_nandc' driver, so it
makes it easier to spot the differences between the two
implementations.

No functional changes intended.

Signed-off-by: default avatarGabor Juhos <j4g8y7@gmail.com>
Reviewed-by: default avatarMd Sadre Alam <quic_mdalam@quicinc.com>
Link: https://patch.msgid.link/20250515-qpic-snand-use-bitmasks-v1-1-11729aeae73b@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4614fd63

drivers/spi/spi-qpic-snand.c

+16 −15
Original line number Diff line number Diff line
@@ -483,7 +483,8 @@ static int qcom_spi_block_erase(struct qcom_nand_controller *snandc) 
	snandc->regs->cmd = snandc->qspi->cmd;

	snandc->regs->addr0 = snandc->qspi->addr1;

	snandc->regs->addr1 = snandc->qspi->addr2;

	snandc->regs->cfg0 = cpu_to_le32(ecc_cfg->cfg0_raw & ~(7 << CW_PER_PAGE));

	snandc->regs->cfg0 = cpu_to_le32((ecc_cfg->cfg0_raw & ~CW_PER_PAGE_MASK) |

					 FIELD_PREP(CW_PER_PAGE_MASK, 0));

	snandc->regs->cfg1 = cpu_to_le32(ecc_cfg->cfg1_raw);

	snandc->regs->exec = cpu_to_le32(1);
@@ -544,8 +545,8 @@ static int qcom_spi_read_last_cw(struct qcom_nand_controller *snandc, 
	snandc->regs->addr0 = (snandc->qspi->addr1 | cpu_to_le32(col));

	snandc->regs->addr1 = snandc->qspi->addr2;



	cfg0 = (ecc_cfg->cfg0_raw & ~(7U << CW_PER_PAGE)) |

		0 << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0_raw & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, 0);

	cfg1 = ecc_cfg->cfg1_raw;

	ecc_bch_cfg = ECC_CFG_ECC_DISABLE;
@@ -687,8 +688,8 @@ static int qcom_spi_read_cw_raw(struct qcom_nand_controller *snandc, u8 *data_bu 
	qcom_clear_bam_transaction(snandc);

	raw_cw = num_cw - 1;



	cfg0 = (ecc_cfg->cfg0_raw & ~(7U << CW_PER_PAGE)) |

				0 << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0_raw & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, 0);

	cfg1 = ecc_cfg->cfg1_raw;

	ecc_bch_cfg = ECC_CFG_ECC_DISABLE;
@@ -808,8 +809,8 @@ static int qcom_spi_read_page_ecc(struct qcom_nand_controller *snandc, 
	snandc->buf_start = 0;

	qcom_clear_read_regs(snandc);



	cfg0 = (ecc_cfg->cfg0 & ~(7U << CW_PER_PAGE)) |

				(num_cw - 1) << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0 & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, num_cw - 1);

	cfg1 = ecc_cfg->cfg1;

	ecc_bch_cfg = ecc_cfg->ecc_bch_cfg;
@@ -904,8 +905,8 @@ static int qcom_spi_read_page_oob(struct qcom_nand_controller *snandc, 
	qcom_clear_read_regs(snandc);

	qcom_clear_bam_transaction(snandc);



	cfg0 = (ecc_cfg->cfg0 & ~(7U << CW_PER_PAGE)) |

				(num_cw - 1) << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0 & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, num_cw - 1);

	cfg1 = ecc_cfg->cfg1;

	ecc_bch_cfg = ecc_cfg->ecc_bch_cfg;
@@ -1015,8 +1016,8 @@ static int qcom_spi_program_raw(struct qcom_nand_controller *snandc, 
	int num_cw = snandc->qspi->num_cw;

	u32 cfg0, cfg1, ecc_bch_cfg;



	cfg0 = (ecc_cfg->cfg0_raw & ~(7U << CW_PER_PAGE)) |

			(num_cw - 1) << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0_raw & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, num_cw - 1);

	cfg1 = ecc_cfg->cfg1_raw;

	ecc_bch_cfg = ECC_CFG_ECC_DISABLE;
@@ -1098,8 +1099,8 @@ static int qcom_spi_program_ecc(struct qcom_nand_controller *snandc, 
	int num_cw = snandc->qspi->num_cw;

	u32 cfg0, cfg1, ecc_bch_cfg, ecc_buf_cfg;



	cfg0 = (ecc_cfg->cfg0 & ~(7U << CW_PER_PAGE)) |

				(num_cw - 1) << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0 & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, num_cw - 1);

	cfg1 = ecc_cfg->cfg1;

	ecc_bch_cfg = ecc_cfg->ecc_bch_cfg;

	ecc_buf_cfg = ecc_cfg->ecc_buf_cfg;
@@ -1175,8 +1176,8 @@ static int qcom_spi_program_oob(struct qcom_nand_controller *snandc, 
	int num_cw = snandc->qspi->num_cw;

	u32 cfg0, cfg1, ecc_bch_cfg, ecc_buf_cfg;



	cfg0 = (ecc_cfg->cfg0 & ~(7U << CW_PER_PAGE)) |

				(num_cw - 1) << CW_PER_PAGE;

	cfg0 = (ecc_cfg->cfg0 & ~CW_PER_PAGE_MASK) |

	       FIELD_PREP(CW_PER_PAGE_MASK, num_cw - 1);

	cfg1 = ecc_cfg->cfg1;

	ecc_bch_cfg = ecc_cfg->ecc_bch_cfg;

	ecc_buf_cfg = ecc_cfg->ecc_buf_cfg;