Commit 2ac33975 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: qcom-geni: do not kill the machine on fifo underrun 



The Qualcomm GENI serial driver did not handle buffer flushing and used
to print discarded characters when the circular buffer was cleared.
Since commit 1788cf6a ("tty: serial: switch from circ_buf to kfifo")
this instead resulted in a hard lockup due to
qcom_geni_serial_send_chunk_fifo() spinning indefinitely in the
interrupt handler.

The underlying bugs have now been fixed, but make sure to output NUL
characters instead of killing the machine if a similar driver bug is
ever reintroduced.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20240704101805.30612-4-johan+linaro@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 507786c5

drivers/tty/serial/qcom_geni_serial.c

+1 −1
Original line number Diff line number Diff line
@@ -878,7 +878,7 @@ static void qcom_geni_serial_send_chunk_fifo(struct uart_port *uport, 
		memset(buf, 0, sizeof(buf));

		tx_bytes = min(remaining, BYTES_PER_FIFO_WORD);



		tx_bytes = uart_fifo_out(uport, buf, tx_bytes);

		uart_fifo_out(uport, buf, tx_bytes);



		iowrite32_rep(uport->membase + SE_GENI_TX_FIFOn, buf, 1);