Commit 2b055bf8 authored by Stephen Boyd's avatar Stephen Boyd Committed by Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_typec: Use dev_err_probe() more 



There's some debug prints here that can be upgraded to dev_err_probe()
so that we don't have to fish out the error messages when a true error
happens. If they're simply probe defers then the kernel will keep silent
but if they're true errors we'll see the errors in the logs.

Cc: Prashant Malani <pmalani@chromium.org>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Acked-by: default avatarPrashant Malani <pmalani@chromium.org>
Link: https://lore.kernel.org/r/20231003003429.1378109-3-swboyd@chromium.org


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent a88f6ef6

drivers/platform/chrome/cros_ec_typec.c

+4 −4
Original line number Diff line number Diff line
@@ -80,28 +80,28 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port, 
	port->mux = fwnode_typec_mux_get(fwnode);

	if (IS_ERR(port->mux)) {

		ret = PTR_ERR(port->mux);

		dev_dbg(dev, "Mux handle not found: %d.\n", ret);

		dev_err_probe(dev, ret, "Mux handle not found\n");

		goto mux_err;

	}



	port->retimer = fwnode_typec_retimer_get(fwnode);

	if (IS_ERR(port->retimer)) {

		ret = PTR_ERR(port->retimer);

		dev_dbg(dev, "Retimer handle not found: %d.\n", ret);

		dev_err_probe(dev, ret, "Retimer handle not found\n");

		goto retimer_sw_err;

	}



	port->ori_sw = fwnode_typec_switch_get(fwnode);

	if (IS_ERR(port->ori_sw)) {

		ret = PTR_ERR(port->ori_sw);

		dev_dbg(dev, "Orientation switch handle not found: %d\n", ret);

		dev_err_probe(dev, ret, "Orientation switch handle not found\n");

		goto ori_sw_err;

	}



	port->role_sw = fwnode_usb_role_switch_get(fwnode);

	if (IS_ERR(port->role_sw)) {

		ret = PTR_ERR(port->role_sw);

		dev_dbg(dev, "USB role switch handle not found: %d\n", ret);

		dev_err_probe(dev, ret, "USB role switch handle not found\n");

		goto role_sw_err;

	}