Commit 2b0ba7b5 authored by Jack Ping CHNG's avatar Jack Ping CHNG Committed by Jakub Kicinski
Browse files

net: pcs: xpcs: mask readl() return value to 16 bits 



readl() returns 32-bit value but Clause 22/45 registers are 16-bit wide.
Masking with 0xFFFF avoids using garbage upper bits.

Signed-off-by: default avatarJack Ping CHNG <jchng@maxlinear.com>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20250716030349.3796806-1-jchng@maxlinear.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 49be1e24

drivers/net/pcs/pcs-xpcs-plat.c

+2 −2
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ static int xpcs_mmio_read_reg_indirect(struct dw_xpcs_plat *pxpcs, 
	switch (pxpcs->reg_width) {

	case 4:

		writel(page, pxpcs->reg_base + (DW_VR_CSR_VIEWPORT << 2));

		ret = readl(pxpcs->reg_base + (ofs << 2));

		ret = readl(pxpcs->reg_base + (ofs << 2)) & 0xffff;

		break;

	default:

		writew(page, pxpcs->reg_base + (DW_VR_CSR_VIEWPORT << 1));
@@ -124,7 +124,7 @@ static int xpcs_mmio_read_reg_direct(struct dw_xpcs_plat *pxpcs, 


	switch (pxpcs->reg_width) {

	case 4:

		ret = readl(pxpcs->reg_base + (csr << 2));

		ret = readl(pxpcs->reg_base + (csr << 2)) & 0xffff;

		break;

	default:

		ret = readw(pxpcs->reg_base + (csr << 1));