Commit 2b2d7ca7 authored by Christian König's avatar Christian König
Browse files

dma-buf: fix incorrect dma-fence documentation v2 



There isn't much worse than documentation giving an incorrect advise.
Grabbing a spinlock while interrupts are disabled usually means that you
must also disable interrupts for all other uses of this spinlock.

Otherwise really hard to debug issues can occur. So fix that invalid
documentation.

v2: use Dmitry's suggestion on the documentation

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> (v1)
Link: https://patchwork.freedesktop.org/patch/msgid/20250211163109.12200-2-christian.koenig@amd.com
parent 4423e607

include/linux/dma-fence.h

+2 −2
Original line number Diff line number Diff line
@@ -169,8 +169,8 @@ struct dma_fence_ops { 
	 * implementation know that there is another driver waiting on the

	 * signal (ie. hw->sw case).

	 *

	 * This function can be called from atomic context, but not

	 * from irq context, so normal spinlocks can be used.

	 * This is called with irq's disabled, so only spinlocks which disable

	 * IRQ's can be used in the code outside of this callback.

	 *

	 * A return value of false indicates the fence already passed,

	 * or some failure occurred that made it impossible to enable