Commit 2b3460cb authored by Aleksandr Mishin's avatar Aleksandr Mishin Committed by Herbert Xu
Browse files

crypto: bcm - Fix pointer arithmetic 



In spu2_dump_omd() value of ptr is increased by ciph_key_len
instead of hash_iv_len which could lead to going beyond the
buffer boundaries.
Fix this bug by changing ciph_key_len to hash_iv_len.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 9d12ba86 ("crypto: brcm - Add Broadcom SPU driver")
Signed-off-by: default avatarAleksandr Mishin <amishin@t-argos.ru>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 616ce45c

drivers/crypto/bcm/spu2.c

+1 −1
Original line number Diff line number Diff line
@@ -495,7 +495,7 @@ static void spu2_dump_omd(u8 *omd, u16 hash_key_len, u16 ciph_key_len, 
	if (hash_iv_len) {

		packet_log("  Hash IV Length %u bytes\n", hash_iv_len);

		packet_dump("  hash IV: ", ptr, hash_iv_len);

		ptr += ciph_key_len;

		ptr += hash_iv_len;

	}



	if (ciph_iv_len) {