Commit 2b3aabc9 authored by Kuogee Hsieh's avatar Kuogee Hsieh Committed by Dmitry Baryshkov
Browse files

drm/msm/dp: delete EV_HPD_INIT_SETUP 



EV_HPD_INIT_SETUP flag is used to trigger the initialization of external
DP host controller. Since external DP host controller initialization had
been incorporated into pm_runtime_resume(), this flag became obsolete.
msm_dp_irq_postinstall() which triggers EV_HPD_INIT_SETUP event is
obsoleted accordingly.

Changes in v4:
-- reworded commit text
-- drop EV_HPD_INIT_SETUP
-- drop msm_dp_irq_postinstall()

Changes in v3:
-- drop EV_HPD_INIT_SETUP and msm_dp_irq_postinstall()

Signed-off-by: default avatarKuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/570075/
Link: https://lore.kernel.org/r/1701472789-25951-7-git-send-email-quic_khsieh@quicinc.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 5814b8bf

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

+0 −4
Original line number Diff line number Diff line
@@ -845,7 +845,6 @@ static int dpu_irq_postinstall(struct msm_kms *kms) 
{

	struct msm_drm_private *priv;

	struct dpu_kms *dpu_kms = to_dpu_kms(kms);

	int i;



	if (!dpu_kms || !dpu_kms->dev)

		return -EINVAL;
@@ -854,9 +853,6 @@ static int dpu_irq_postinstall(struct msm_kms *kms) 
	if (!priv)

		return -EINVAL;



	for (i = 0; i < ARRAY_SIZE(priv->dp); i++)

		msm_dp_irq_postinstall(priv->dp[i]);



	return 0;

}

drivers/gpu/drm/msm/dp/dp_display.c

+0 −16
Original line number Diff line number Diff line
@@ -54,7 +54,6 @@ enum { 
enum {

	EV_NO_EVENT,

	/* hpd events */

	EV_HPD_INIT_SETUP,

	EV_HPD_PLUG_INT,

	EV_IRQ_HPD_INT,

	EV_HPD_UNPLUG_INT,
@@ -1078,8 +1077,6 @@ static int hpd_event_thread(void *data) 
		spin_unlock_irqrestore(&dp_priv->event_lock, flag);



		switch (todo->event_id) {

		case EV_HPD_INIT_SETUP:

			break;

		case EV_HPD_PLUG_INT:

			dp_hpd_plug_handle(dp_priv, todo->data);

			break;
@@ -1359,19 +1356,6 @@ void __exit msm_dp_unregister(void) 
	platform_driver_unregister(&dp_display_driver);

}



void msm_dp_irq_postinstall(struct msm_dp *dp_display)

{

	struct dp_display_private *dp;



	if (!dp_display)

		return;



	dp = container_of(dp_display, struct dp_display_private, dp_display);



	if (!dp_display->is_edp)

		dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 0);

}



bool msm_dp_wide_bus_available(const struct msm_dp *dp_display)

{

	struct dp_display_private *dp;

drivers/gpu/drm/msm/msm_drv.h

+0 −5
Original line number Diff line number Diff line
@@ -386,7 +386,6 @@ int __init msm_dp_register(void); 
void __exit msm_dp_unregister(void);

int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,

			 struct drm_encoder *encoder);

void msm_dp_irq_postinstall(struct msm_dp *dp_display);

void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp_display);



bool msm_dp_wide_bus_available(const struct msm_dp *dp_display);
@@ -406,10 +405,6 @@ static inline int msm_dp_modeset_init(struct msm_dp *dp_display, 
	return -EINVAL;

}



static inline void msm_dp_irq_postinstall(struct msm_dp *dp_display)

{

}



static inline void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp_display)

{

}