Commit 2b72e50c authored by Rob Clark's avatar Rob Clark Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: Ratelimit framedone timeout msgs 



When we start getting these, we get a *lot*.  So ratelimit it to not
flood dmesg.

Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Patchwork: https://patchwork.freedesktop.org/patch/571584/
Link: https://lore.kernel.org/r/20231211182000.218088-1-robdclark@gmail.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent eaa647cd

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

+4 −1
Original line number Diff line number Diff line
@@ -39,6 +39,9 @@ 
#define DPU_ERROR_ENC(e, fmt, ...) DPU_ERROR("enc%d " fmt,\

		(e) ? (e)->base.base.id : -1, ##__VA_ARGS__)



#define DPU_ERROR_ENC_RATELIMITED(e, fmt, ...) DPU_ERROR_RATELIMITED("enc%d " fmt,\

		(e) ? (e)->base.base.id : -1, ##__VA_ARGS__)



/*

 * Two to anticipate panels that can do cmd/vid dynamic switching

 * plan is to create all possible physical encoder types, and switch between
@@ -2279,7 +2282,7 @@ static void dpu_encoder_frame_done_timeout(struct timer_list *t) 
		return;

	}



	DPU_ERROR_ENC(dpu_enc, "frame done timeout\n");

	DPU_ERROR_ENC_RATELIMITED(dpu_enc, "frame done timeout\n");



	if (atomic_inc_return(&dpu_enc->frame_done_timeout_cnt) == 1)

		msm_disp_snapshot_state(drm_enc->dev);

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h

+1 −0
Original line number Diff line number Diff line
@@ -51,6 +51,7 @@ 
	} while (0)



#define DPU_ERROR(fmt, ...) pr_err("[dpu error]" fmt, ##__VA_ARGS__)

#define DPU_ERROR_RATELIMITED(fmt, ...) pr_err_ratelimited("[dpu error]" fmt, ##__VA_ARGS__)



/**

 * ktime_compare_safe - compare two ktime structures