Commit 2b959bdd authored by Colin Ian King's avatar Colin Ian King Committed by Rafael J. Wysocki
Browse files

ACPI: thermal_lib: Initialize temp_decik to zero 



Static analysis with clang scan build is warning that uninitialized
data is being passed into various functions. Stop these warnings by
initializing temp_decik to zero.

Cleans up clang scan warnings in lines 106, 125, 146 and 164 such as:
drivers/acpi/thermal_lib.c:106:9: warning: 2nd function call argument
is an uninitialized value [core.CallAndMessage]

Kudos to Dan Carpenter for the deeper analysis of this issue.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b401b621

drivers/acpi/thermal_lib.c

+4 −4
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static int thermal_temp(int error, int temp_decik, int *ret_temp) 
 */

int thermal_acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)

{

	int temp_decik;

	int temp_decik = 0;

	int ret = acpi_active_trip_temp(adev, id, &temp_decik);



	return thermal_temp(ret, temp_decik, ret_temp);
@@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_active_trip_temp); 
 */

int thermal_acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)

{

	int temp_decik;

	int temp_decik = 0;

	int ret = acpi_passive_trip_temp(adev, &temp_decik);



	return thermal_temp(ret, temp_decik, ret_temp);
@@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_passive_trip_temp); 
 */

int thermal_acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)

{

	int temp_decik;

	int temp_decik = 0;

	int ret = acpi_hot_trip_temp(adev, &temp_decik);



	return thermal_temp(ret, temp_decik, ret_temp);
@@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_hot_trip_temp); 
 */

int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)

{

	int temp_decik;

	int temp_decik = 0;

	int ret = acpi_critical_trip_temp(adev, &temp_decik);



	return thermal_temp(ret, temp_decik, ret_temp);