Commit 2bb63794 authored by Taegu Ha's avatar Taegu Ha Committed by Jakub Kicinski
Browse files

ppp: require CAP_NET_ADMIN in target netns for unattached ioctls 



/dev/ppp open is currently authorized against file->f_cred->user_ns,
while unattached administrative ioctls operate on current->nsproxy->net_ns.

As a result, a local unprivileged user can create a new user namespace
with CLONE_NEWUSER, gain CAP_NET_ADMIN only in that new user namespace,
and still issue PPPIOCNEWUNIT, PPPIOCATTACH, or PPPIOCATTCHAN against
an inherited network namespace.

Require CAP_NET_ADMIN in the user namespace that owns the target network
namespace before handling unattached PPP administrative ioctls.

This preserves normal pppd operation in the network namespace it is
actually privileged in, while rejecting the userns-only inherited-netns
case.

Fixes: 273ec51d ("net: ppp_generic - introduce net-namespace functionality v2")
Signed-off-by: default avatarTaegu Ha <hataegu0826@gmail.com>
Link: https://patch.msgid.link/20260409071117.4354-1-hataegu0826@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e802cd8c

drivers/net/ppp/ppp_generic.c

+3 −0
Original line number Diff line number Diff line
@@ -1057,6 +1057,9 @@ static int ppp_unattached_ioctl(struct net *net, struct ppp_file *pf, 
	struct ppp_net *pn;

	int __user *p = (int __user *)arg;



	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

		return -EPERM;



	switch (cmd) {

	case PPPIOCNEWUNIT:

		/* Create a new ppp unit */