Commit 2bcf73b2 authored by Baochen Qiang's avatar Baochen Qiang Committed by Jeff Johnson
Browse files

wifi: ath11k: don't use static variables in ath11k_debugfs_fw_stats_process() 



Currently ath11k_debugfs_fw_stats_process() is using static variables to count
firmware stat events. Taking num_vdev as an example, if for whatever reason (
say ar->num_started_vdevs is 0 or firmware bug etc.) the following condition

	(++num_vdev) == total_vdevs_started

is not met, is_end is not set thus num_vdev won't be cleared. Next time when
firmware stats is requested again, even if everything is working fine, we will
fail due to the condition above will never be satisfied.

The same applies to num_bcn as well.

Change to use non-static counters so that we have a chance to clear them each
time firmware stats is requested. Currently only ath11k_fw_stats_request() and
ath11k_debugfs_fw_stats_request() are requesting firmware stats, so clear
counters there.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37

Fixes: da3a9d3c ("ath11k: refactor debugfs code into debugfs.c")
Signed-off-by: default avatarBaochen Qiang <quic_bqiang@quicinc.com>
Acked-by: default avatarKalle Valo <kvalo@kernel.org>
Reviewed-by: default avatarVasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250220082448.31039-3-quic_bqiang@quicinc.com


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent 9f6e82d1

drivers/net/wireless/ath/ath11k/core.h

+2 −0
Original line number Diff line number Diff line
@@ -600,6 +600,8 @@ struct ath11k_fw_stats { 
	struct list_head pdevs;

	struct list_head vdevs;

	struct list_head bcn;

	u32 num_vdev_recvd;

	u32 num_bcn_recvd;

};



struct ath11k_dbg_htt_stats {

drivers/net/wireless/ath/ath11k/debugfs.c

+7 −9
Original line number Diff line number Diff line
@@ -98,6 +98,8 @@ static void ath11k_debugfs_fw_stats_reset(struct ath11k *ar) 
	spin_lock_bh(&ar->data_lock);

	ath11k_fw_stats_pdevs_free(&ar->fw_stats.pdevs);

	ath11k_fw_stats_vdevs_free(&ar->fw_stats.vdevs);

	ar->fw_stats.num_vdev_recvd = 0;

	ar->fw_stats.num_bcn_recvd = 0;

	spin_unlock_bh(&ar->data_lock);

}
@@ -106,7 +108,6 @@ void ath11k_debugfs_fw_stats_process(struct ath11k *ar, struct ath11k_fw_stats * 
	struct ath11k_base *ab = ar->ab;

	struct ath11k_pdev *pdev;

	bool is_end;

	static unsigned int num_vdev, num_bcn;

	size_t total_vdevs_started = 0;

	int i;
@@ -131,15 +132,14 @@ void ath11k_debugfs_fw_stats_process(struct ath11k *ar, struct ath11k_fw_stats * 
				total_vdevs_started += ar->num_started_vdevs;

		}



		is_end = ((++num_vdev) == total_vdevs_started);

		is_end = ((++ar->fw_stats.num_vdev_recvd) == total_vdevs_started);



		list_splice_tail_init(&stats->vdevs,

				      &ar->fw_stats.vdevs);



		if (is_end) {

		if (is_end)

			complete(&ar->fw_stats_done);

			num_vdev = 0;

		}



		return;

	}
@@ -151,15 +151,13 @@ void ath11k_debugfs_fw_stats_process(struct ath11k *ar, struct ath11k_fw_stats * 
		/* Mark end until we reached the count of all started VDEVs

		 * within the PDEV

		 */

		is_end = ((++num_bcn) == ar->num_started_vdevs);

		is_end = ((++ar->fw_stats.num_bcn_recvd) == ar->num_started_vdevs);



		list_splice_tail_init(&stats->bcn,

				      &ar->fw_stats.bcn);



		if (is_end) {

		if (is_end)

			complete(&ar->fw_stats_done);

			num_bcn = 0;

		}

	}

}

drivers/net/wireless/ath/ath11k/mac.c

+2 −0
Original line number Diff line number Diff line
@@ -9391,6 +9391,8 @@ static int ath11k_fw_stats_request(struct ath11k *ar, 


	spin_lock_bh(&ar->data_lock);

	ath11k_fw_stats_pdevs_free(&ar->fw_stats.pdevs);

	ar->fw_stats.num_vdev_recvd = 0;

	ar->fw_stats.num_bcn_recvd = 0;

	spin_unlock_bh(&ar->data_lock);



	reinit_completion(&ar->fw_stats_complete);