Commit 2bd0c721 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Bjorn Helgaas
Browse files

PCI: Check resource_size() separately 

Instead of chaining logic inside if () condition so that multiple lines are
required, make !resource_size() a separate check and use continue.

Link: https://lore.kernel.org/r/20241216175632.4175-10-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Tested-by: default avatarXiaochun Lee <lixc17@lenovo.com>
parent cbd38438

drivers/pci/setup-bus.c

+5 −2
Original line number Diff line number Diff line
@@ -285,8 +285,11 @@ static void assign_requested_resources_sorted(struct list_head *head, 
	list_for_each_entry(dev_res, head, list) {

		res = dev_res->res;

		idx = res - &dev_res->dev->resource[0];

		if (resource_size(res) &&

		    pci_assign_resource(dev_res->dev, idx)) {



		if (!resource_size(res))

			continue;



		if (pci_assign_resource(dev_res->dev, idx)) {

			if (fail_head) {

				/*

				 * If the failed resource is a ROM BAR and