Unverified Commit 2bf1877b authored by Zilin Guan's avatar Zilin Guan Committed by Ilpo Järvinen
Browse files

platform/x86/amd: Fix memory leak in wbrf_record() 



The tmp buffer is allocated using kcalloc() but is not freed if
acpi_evaluate_dsm() fails. This causes a memory leak in the error path.

Fix this by explicitly freeing the tmp buffer in the error handling
path of acpi_evaluate_dsm().

Fixes: 58e82a62 ("platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature")
Suggested-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Co-developed-by: default avatarJianhao Xu <jianhao.xu@seu.edu.cn>
Signed-off-by: default avatarJianhao Xu <jianhao.xu@seu.edu.cn>
Signed-off-by: default avatarZilin Guan <zilin@seu.edu.cn>
Link: https://patch.msgid.link/20260106091318.747019-1-zilin@seu.edu.cn


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 3113bcf4

drivers/platform/x86/amd/wbrf.c

+3 −1
Original line number Diff line number Diff line
@@ -104,8 +104,10 @@ static int wbrf_record(struct acpi_device *adev, uint8_t action, struct wbrf_ran 
	obj = acpi_evaluate_dsm(adev->handle, &wifi_acpi_dsm_guid,

				WBRF_REVISION, WBRF_RECORD, &argv4);



	if (!obj)

	if (!obj) {

		kfree(tmp);

		return -EINVAL;

	}



	if (obj->type != ACPI_TYPE_INTEGER) {

		ret = -EINVAL;