Commit 2c2192e5 authored by William Liu's avatar William Liu Committed by Jakub Kicinski
Browse files

net/sched: Remove unnecessary WARNING condition for empty child qdisc in htb_activate 



The WARN_ON trigger based on !cl->leaf.q->q.qlen is unnecessary in
htb_activate. htb_dequeue_tree already accounts for that scenario.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarWilliam Liu <will@willsroot.io>
Reviewed-by: default avatarSavino Dicanosa <savy@syst3mfailure.io>
Link: https://patch.msgid.link/20250819033632.579854-1-will@willsroot.io


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 15de71d0

net/sched/sch_htb.c

+1 −1
Original line number Diff line number Diff line
@@ -592,7 +592,7 @@ htb_change_class_mode(struct htb_sched *q, struct htb_class *cl, s64 *diff) 
 */

static inline void htb_activate(struct htb_sched *q, struct htb_class *cl)

{

	WARN_ON(cl->level || !cl->leaf.q || !cl->leaf.q->q.qlen);

	WARN_ON(cl->level || !cl->leaf.q);



	if (!cl->prio_activity) {

		cl->prio_activity = 1 << cl->prio;