Commit 2c5ac026 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Jakub Kicinski
Browse files

net: phy: Introduce PHY_ID_SIZE — minimum size for PHY ID string 



The PHY_ID_FMT defines the format specifier "%s:%02x" to form
the PHY ID string, where the maximum of the first part is defined
in MII_BUS_ID_SIZE, including NUL terminator, and the second part
is implied to be 3 as the maximum address is limited to 32, meaning
that 2 hex digits is more than enough, plus ':' (colon) delimiter.
However, some drivers, which are using PHY_ID_FMT, customise buffer
size and do that incorrectly. Introduce a new constant PHY_ID_SIZE
that makes the minimum required size explicit, so drivers are
encouraged to use it.

Suggested-by: default avatar"Russell King (Oracle)" <linux@armlinux.org.uk>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20250324144751.1271761-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4f74a45c

include/linux/phy.h

+1 −0
Original line number Diff line number Diff line
@@ -292,6 +292,7 @@ static inline long rgmii_clock(int speed) 


/* Used when trying to connect to a specific phy (mii bus id:phy device id) */

#define PHY_ID_FMT "%s:%02x"

#define PHY_ID_SIZE	(MII_BUS_ID_SIZE + 3)



#define MII_BUS_ID_SIZE	61