Commit 2c606d13 authored by Arınç ÜNAL's avatar Arınç ÜNAL Committed by David S. Miller
Browse files

net: dsa: mt7530: fix port mirroring for MT7988 SoC switch 



The "MT7988A Wi-Fi 7 Generation Router Platform: Datasheet (Open Version)
v0.1" document shows bits 16 to 18 as the MIRROR_PORT field of the CPU
forward control register. Currently, the MT7530 DSA subdriver configures
bits 0 to 2 of the CPU forward control register which breaks the port
mirroring feature for the MT7988 SoC switch.

Fix this by using the MT7531_MIRROR_PORT_GET() and MT7531_MIRROR_PORT_SET()
macros which utilise the correct bits.

Fixes: 110c18bf ("net: dsa: mt7530: introduce driver for MT7988 built-in switch")
Signed-off-by: default avatarArınç ÜNAL <arinc.unal@arinc9.com>
Acked-by: default avatarDaniel Golle <daniel@makrotopia.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d59cf049

drivers/net/dsa/mt7530.c

+6 −4
Original line number Diff line number Diff line
@@ -1883,13 +1883,15 @@ mt7530_port_vlan_del(struct dsa_switch *ds, int port, 


static int mt753x_mirror_port_get(unsigned int id, u32 val)

{

	return (id == ID_MT7531) ? MT7531_MIRROR_PORT_GET(val) :

	return (id == ID_MT7531 || id == ID_MT7988) ?

		       MT7531_MIRROR_PORT_GET(val) :

		       MIRROR_PORT(val);

}



static int mt753x_mirror_port_set(unsigned int id, u32 val)

{

	return (id == ID_MT7531) ? MT7531_MIRROR_PORT_SET(val) :

	return (id == ID_MT7531 || id == ID_MT7988) ?

		       MT7531_MIRROR_PORT_SET(val) :

		       MIRROR_PORT(val);

}