Commit 2c68ac48 authored by Ivan Abramov's avatar Ivan Abramov Committed by Sebastian Reichel
Browse files

power: supply: max17040: Check iio_read_channel_processed() return code



Since iio_read_channel_processed() may fail, return its exit code on error.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 814755c4 ("power: max17040: get thermal data from adc if available")
Signed-off-by: default avatarIvan Abramov <i.abramov@mt-integration.ru>
Link: https://patch.msgid.link/20251008133648.559286-1-i.abramov@mt-integration.ru


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 92ec7e7b
Loading
Loading
Loading
Loading
+5 −1
Original line number Diff line number Diff line
@@ -388,6 +388,7 @@ static int max17040_get_property(struct power_supply *psy,
			    union power_supply_propval *val)
{
	struct max17040_chip *chip = power_supply_get_drvdata(psy);
	int ret;

	switch (psp) {
	case POWER_SUPPLY_PROP_ONLINE:
@@ -410,7 +411,10 @@ static int max17040_get_property(struct power_supply *psy,
		if (!chip->channel_temp)
			return -ENODATA;

		iio_read_channel_processed(chip->channel_temp, &val->intval);
		ret = iio_read_channel_processed(chip->channel_temp, &val->intval);
		if (ret)
			return ret;

		val->intval /= 100; /* Convert from milli- to deci-degree */

		break;