Commit 2c6c34e0 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

gpiolib: acpi: Improve struct acpi_gpio_info memory footprint 



The struct acpi_gpio_info has two boolean members that are located
not close to each other making two gaps due to alignment requirements.
Group them to improve memory footprint.

`pahole` difference before and after (on 32-bit):

-       /* size: 36, cachelines: 1, members: 9 */
-       /* sum members: 30, holes: 2, sum holes: 6 */

+       /* size: 32, cachelines: 1, members: 9 */
+       /* sum members: 30, holes: 1, sum holes: 2 */

Acked-by: default avatarMika Westerberg <westeri@kernel.org>
Link: https://lore.kernel.org/r/20250403160034.2680485-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 0af2f6be

drivers/gpio/gpiolib-acpi.c

+2 −2
Original line number Diff line number Diff line
@@ -96,10 +96,10 @@ struct acpi_gpio_chip { 
 * @adev: reference to ACPI device which consumes GPIO resource

 * @flags: GPIO initialization flags

 * @gpioint: if %true this GPIO is of type GpioInt otherwise type is GpioIo

 * @wake_capable: wake capability as provided by ACPI

 * @pin_config: pin bias as provided by ACPI

 * @polarity: interrupt polarity as provided by ACPI

 * @triggering: triggering type as provided by ACPI

 * @wake_capable: wake capability as provided by ACPI

 * @debounce: debounce timeout as provided by ACPI

 * @quirks: Linux specific quirks as provided by struct acpi_gpio_mapping

 */
@@ -107,10 +107,10 @@ struct acpi_gpio_info { 
	struct acpi_device *adev;

	enum gpiod_flags flags;

	bool gpioint;

	bool wake_capable;

	int pin_config;

	int polarity;

	int triggering;

	bool wake_capable;

	unsigned int debounce;

	unsigned int quirks;

};