Commit 2c863dbb authored by Ethan Tidmore's avatar Ethan Tidmore Committed by Greg Kroah-Hartman
Browse files

usb: gadget: f_hid: Add missing error code 



Currently in cdev_alloc() error path no error code is assigned.

Assign error code '-ENOMEM'.

Detected by Smatch:
drivers/usb/gadget/function/f_hid.c:1291 hidg_bind()
warn: missing error code 'status'

Fixes: 81ebd43c ("usb: gadget: f_hid: don't call cdev_init while cdev in use")
Signed-off-by: default avatarEthan Tidmore <ethantidmore06@gmail.com>
Acked-by: default avatarPeter Korsgaard <peter@korsgaard.com>
Reviewed-by: default avatarMichael Zimmermann <sigmaepsilon92@gmail.com>
Link: https://patch.msgid.link/20260402180008.64233-1-ethantidmore06@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40b17a34

drivers/usb/gadget/function/f_hid.c

+3 −1
Original line number Diff line number Diff line
@@ -1278,8 +1278,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f) 


	/* create char device */

	hidg->cdev = cdev_alloc();

	if (!hidg->cdev)

	if (!hidg->cdev) {

		status = -ENOMEM;

		goto fail_free_all;

	}

	hidg->cdev->ops = &f_hidg_fops;



	status = cdev_device_add(hidg->cdev, &hidg->dev);