Commit 2d4d6bda authored by Luis Henriques (SUSE)'s avatar Luis Henriques (SUSE) Committed by Theodore Ts'o
Browse files

ext4: use ext4_update_inode_fsync_trans() helper in inode creation 



Call helper function ext4_update_inode_fsync_trans() instead of open
coding it in __ext4_new_inode().  This helper checks both that the handle
is valid *and* that it hasn't been aborted due to some fatal error in the
journalling layer, using is_handle_aborted().

Signed-off-by: default avatarLuis Henriques (SUSE) <luis.henriques@linux.dev>
Link: https://patch.msgid.link/20240527161447.21434-1-luis.henriques@linux.dev


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 7378e899

fs/ext4/ialloc.c

+1 −4
Original line number Diff line number Diff line
@@ -1336,10 +1336,7 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap, 
		}

	}



	if (ext4_handle_valid(handle)) {

		ei->i_sync_tid = handle->h_transaction->t_tid;

		ei->i_datasync_tid = handle->h_transaction->t_tid;

	}

	ext4_update_inode_fsync_trans(handle, inode, 1);



	err = ext4_mark_inode_dirty(handle, inode);

	if (err) {