Commit 2d5c9dd2 authored by zhangxiangqian's avatar zhangxiangqian Committed by Jakub Kicinski
Browse files

net: usb: cdc_ether: don't spew notifications 



The usbnet_link_change function is not called, if the link has not changed.

...
[16913.807393][ 3] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 12 may have been dropped
[16913.822266][ 2] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 12 may have been dropped
[16913.826296][ 2] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 11 may have been dropped
...

kevent 11 is scheduled too frequently and may affect other event schedules.

Signed-off-by: default avatarzhangxiangqian <zhangxiangqian@kylinos.cn>
Acked-by: default avatarOliver Neukum <oneukum@suse.com>
Link: https://patch.msgid.link/1723109985-11996-1-git-send-email-zhangxiangqian@kylinos.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 916b7d31

drivers/net/usb/cdc_ether.c

+2 −1
Original line number Diff line number Diff line
@@ -418,6 +418,7 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb) 
	case USB_CDC_NOTIFY_NETWORK_CONNECTION:

		netif_dbg(dev, timer, dev->net, "CDC: carrier %s\n",

			  event->wValue ? "on" : "off");

		if (netif_carrier_ok(dev->net) != !!event->wValue)

			usbnet_link_change(dev, !!event->wValue, 0);

		break;

	case USB_CDC_NOTIFY_SPEED_CHANGE:	/* tx/rx rates */