Commit 2d608ce6 authored by Sai Teja Pottumuttu's avatar Sai Teja Pottumuttu Committed by Gustavo Sousa
Browse files

drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks 



With Xe3p_LPD, the SKL_BOTTOM_COLOR_GAMMA_ENABLE and
SKL_BOTTOM_COLOR_CSC_ENABLE bits are being removed. Thus, we need not
set gamma_enable nor csc_enable in crtc_state.

Note that GAMMA_MODE.POST_CSC_GAMMA_ENABLE and CSC_MODE.ICL_CSC_ENABLE
are the documented alternatives for the bottom color bits being removed.
But as these suggested bits are being checked in state checker as part
of gamma_mode, csc_mode fields and as gamma_enable/csc_enable are not
being used anywhere else functionally post ICL, we need not set these
fields in crtc_state.

Bspec: 69734
Signed-off-by: default avatarSai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Reviewed-by: default avatarChaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Link: https://patch.msgid.link/20251103-xe3p_lpd-basic-enabling-v3-7-00e87b510ae7@intel.com


Signed-off-by: default avatarGustavo Sousa <gustavo.sousa@intel.com>
parent 8d8efb83

drivers/gpu/drm/i915/display/intel_color.c

+7 −6
Original line number Diff line number Diff line
@@ -1090,12 +1090,12 @@ static void skl_get_config(struct intel_crtc_state *crtc_state) 
{

	struct intel_display *display = to_intel_display(crtc_state);

	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);

	u32 tmp;



	crtc_state->gamma_mode = hsw_read_gamma_mode(crtc);

	crtc_state->csc_mode = ilk_read_csc_mode(crtc);



	tmp = intel_de_read(display, SKL_BOTTOM_COLOR(crtc->pipe));

	if (DISPLAY_VER(display) < 35) {

		u32 tmp = intel_de_read(display, SKL_BOTTOM_COLOR(crtc->pipe));



		if (tmp & SKL_BOTTOM_COLOR_GAMMA_ENABLE)

			crtc_state->gamma_enable = true;
@@ -1103,6 +1103,7 @@ static void skl_get_config(struct intel_crtc_state *crtc_state) 
		if (tmp & SKL_BOTTOM_COLOR_CSC_ENABLE)

			crtc_state->csc_enable = true;

	}

}



static void skl_color_commit_arm(struct intel_dsb *dsb,

				 const struct intel_crtc_state *crtc_state)