Unverified Commit 2d85ecd6 authored by Franz Schnyder's avatar Franz Schnyder Committed by Mark Brown
Browse files

regulator: pf9453: Respect IRQ trigger settings from firmware 



The datasheet specifies, that the IRQ_B pin is pulled low when any
unmasked interrupt bit status is changed, and it is released high once
the application processor reads the INT1 register. As it specifies a
level-low behavior, it should not force a falling-edge interrupt.

Remove the IRQF_TRIGGER_FALLING to not force the falling-edge interrupt
and instead rely on the flag from the device tree.

Fixes: 0959b670 ("regulator: pf9453: add PMIC PF9453 support")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarFranz Schnyder <franz.schnyder@toradex.com>
Link: https://patch.msgid.link/20260218102518.238943-2-fra.schnyder@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 23942b71

drivers/regulator/pf9453-regulator.c

+1 −1
Original line number Diff line number Diff line
@@ -809,7 +809,7 @@ static int pf9453_i2c_probe(struct i2c_client *i2c) 
	}



	ret = devm_request_threaded_irq(pf9453->dev, pf9453->irq, NULL, pf9453_irq_handler,

					(IRQF_TRIGGER_FALLING | IRQF_ONESHOT),

					IRQF_ONESHOT,

					"pf9453-irq", pf9453);

	if (ret)

		return dev_err_probe(pf9453->dev, ret, "Failed to request IRQ: %d\n", pf9453->irq);