Commit 2db48d8b authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Ingo Molnar
Browse files

arm64: uaccess: Use unsafe wrappers for ASM GOTO 



Clang propagates a provided label, which is outside of a cleanup scope to
ASM GOTO despite the fact that __raw_get_mem() has a local label for that
purpose:

  "error: cannot jump from this asm goto statement to one of its possible targets"

Using the unsafe wrapper with the extra local label indirection cures that.

Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 43cc54d8

arch/arm64/include/asm/uaccess.h

+2 −2
Original line number Diff line number Diff line
@@ -422,9 +422,9 @@ static __must_check __always_inline bool user_access_begin(const void __user *pt 
}

#define user_access_begin(a,b)	user_access_begin(a,b)

#define user_access_end()	uaccess_ttbr0_disable()

#define unsafe_put_user(x, ptr, label) \

#define arch_unsafe_put_user(x, ptr, label) \

	__raw_put_mem("sttr", x, uaccess_mask_ptr(ptr), label, U)

#define unsafe_get_user(x, ptr, label) \

#define arch_unsafe_get_user(x, ptr, label) \

	__raw_get_mem("ldtr", x, uaccess_mask_ptr(ptr), label, U)



/*