Commit 2df2c6ed authored by Thorsten Blum's avatar Thorsten Blum Committed by David Sterba
Browse files

btrfs: replace deprecated strncpy() with strscpy() 

strncpy() is deprecated for NUL-terminated destination buffers. Use
strscpy() instead and don't zero-initialize the param array.

Link: https://github.com/KSPP/linux/issues/90


Cc: linux-hardening@vger.kernel.org
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 5a4041f2

fs/btrfs/sysfs.c

+2 −2
Original line number Diff line number Diff line
@@ -1330,13 +1330,13 @@ MODULE_PARM_DESC(read_policy, 


int btrfs_read_policy_to_enum(const char *str, s64 *value_ret)

{

	char param[32] = { 0 };

	char param[32];

	char __maybe_unused *value_str;



	if (!str || strlen(str) == 0)

		return 0;



	strncpy(param, str, sizeof(param) - 1);

	strscpy(param, str);



#ifdef CONFIG_BTRFS_EXPERIMENTAL

	/* Separate value from input in policy:value format. */