Commit 2e1136ac authored by Haotian Zhang's avatar Haotian Zhang Committed by Vinod Koul
Browse files

dmaengine: omap-dma: fix dma_pool resource leak in error paths 



The dma_pool created by dma_pool_create() is not destroyed when
dma_async_device_register() or of_dma_controller_register() fails,
causing a resource leak in the probe error paths.

Add dma_pool_destroy() in both error paths to properly release the
allocated dma_pool resource.

Fixes: 7bedaa55 ("dmaengine: add OMAP DMA engine driver")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251103073018.643-1-vulab@iscas.ac.cn


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3f747004

drivers/dma/ti/omap-dma.c

+4 −0
Original line number Diff line number Diff line
@@ -1808,6 +1808,8 @@ static int omap_dma_probe(struct platform_device *pdev) 
	if (rc) {

		pr_warn("OMAP-DMA: failed to register slave DMA engine device: %d\n",

			rc);

		if (od->ll123_supported)

			dma_pool_destroy(od->desc_pool);

		omap_dma_free(od);

		return rc;

	}
@@ -1823,6 +1825,8 @@ static int omap_dma_probe(struct platform_device *pdev) 
		if (rc) {

			pr_warn("OMAP-DMA: failed to register DMA controller\n");

			dma_async_device_unregister(&od->ddev);

			if (od->ll123_supported)

				dma_pool_destroy(od->desc_pool);

			omap_dma_free(od);

		}

	}