Commit 2e19a3b5 authored by Javier Carrasco's avatar Javier Carrasco Committed by Kalle Valo
Browse files

wifi: brcmfmac: release 'root' node in all execution paths 



The fixed patch introduced an additional condition to enter the scope
where the 'root' device_node is released (!settings->board_type,
currently 'err'), which avoid decrementing the refcount with a call to
of_node_put() if that second condition is not satisfied.

Move the call to of_node_put() to the point where 'root' is no longer
required to avoid leaking the resource if err is not zero.

Cc: stable@vger.kernel.org
Fixes: 7682de8b ("wifi: brcmfmac: of: Fetch Apple properties")
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241030-brcmfmac-of-cleanup-v1-1-0b90eefb4279@gmail.com
parent 5255ee95

drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c

+1 −2
Original line number Diff line number Diff line
@@ -112,9 +112,8 @@ int brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, 
		}

		strreplace(board_type, '/', '-');

		settings->board_type = board_type;



		of_node_put(root);

	}

	of_node_put(root);



	clk = devm_clk_get_optional_enabled_with_rate(dev, "lpo", 32768);

	if (IS_ERR(clk))