Commit 2e21557d authored by Chi Zhiling's avatar Chi Zhiling Committed by Namjae Jeon
Browse files

exfat: remove the check for infinite cluster chain loop 



The infinite cluster chain loop check is not work because the
loop will terminate when fclus reaches the parameter cluster,
and the parameter cluster value is never greater than
ei->valid_size.

The following relationship holds:
'fclus' < 'cluster' ≤ ei->valid_size ≤ sb->num_clusters

The check would only be triggered if a cluster number greater than
sb->num_clusters is passed, but no caller currently does this.

Signed-off-by: default avatarChi Zhiling <chizhiling@kylinos.cn>
Reviewed-by: default avatarYuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
parent 5e205c48

fs/exfat/cache.c

+0 −10
Original line number Diff line number Diff line
@@ -238,8 +238,6 @@ int exfat_get_cluster(struct inode *inode, unsigned int cluster, 
		unsigned int *last_dclus, int allow_eof)

{

	struct super_block *sb = inode->i_sb;

	struct exfat_sb_info *sbi = EXFAT_SB(sb);

	unsigned int limit = sbi->num_clusters;

	struct exfat_inode_info *ei = EXFAT_I(inode);

	struct exfat_cache_id cid;

	unsigned int content;
@@ -279,14 +277,6 @@ int exfat_get_cluster(struct inode *inode, unsigned int cluster, 
		return 0;



	while (*fclus < cluster) {

		/* prevent the infinite loop of cluster chain */

		if (*fclus > limit) {

			exfat_fs_error(sb,

				"detected the cluster chain loop (i_pos %u)",

				(*fclus));

			return -EIO;

		}



		if (exfat_ent_get(sb, *dclus, &content, NULL))

			return -EIO;