Commit 2e38abef authored by Cezar Chiru's avatar Cezar Chiru Committed by Andi Shyti
Browse files

i2c: pcf8584: Fix do not use assignment inside if conditional 



Assign inside of 'if' conditional is not allowed. Move assignment from
inside 'if' conditional, to one line before each 'if'conditional statement
that caused errors.
Enforce errors fixing based on checkpatch.pl output on file.

Signed-off-by: default avatarCezar Chiru <chiru.cezar.89@gmail.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251018091258.5266-3-chiru.cezar.89@gmail.com
parent faef2789

drivers/i2c/algos/i2c-algo-pcf.c

+15 −13
Original line number Diff line number Diff line
@@ -139,38 +139,38 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap) 
	 * check to see S1 now used as R/W ctrl -

	 * PCF8584 does that when ESO is zero

	 */

	if (((temp = get_pcf(adap, 1)) & 0x7f) != (0)) {

	temp = get_pcf(adap, 1);

	if ((temp & 0x7f) != 0)

		return -ENXIO; /* definitely not PCF8584 */

	}



	/* load own address in S0, effective address is (own << 1) */

	i2c_outb(adap, get_own(adap));

	/* check it's really written */

	if ((temp = i2c_inb(adap)) != get_own(adap)) {

	temp = i2c_inb(adap);

	if (temp != get_own(adap))

		return -ENXIO;

	}



	/* S1=0xA0, next byte in S2 */

	set_pcf(adap, 1, I2C_PCF_PIN | I2C_PCF_ES1);

	/* check to see S2 now selected */

	if (((temp = get_pcf(adap, 1)) & 0x7f) != I2C_PCF_ES1) {

	temp = get_pcf(adap, 1);

	if ((temp & 0x7f) != I2C_PCF_ES1)

		return -ENXIO;

	}



	/* load clock register S2 */

	i2c_outb(adap, get_clock(adap));

	/* check it's really written, the only 5 lowest bits does matter */

	if (((temp = i2c_inb(adap)) & 0x1f) != get_clock(adap)) {

	temp = i2c_inb(adap);

	if ((temp & 0x1f) != get_clock(adap))

		return -ENXIO;

	}



	/* Enable serial interface, idle, S0 selected */

	set_pcf(adap, 1, I2C_PCF_IDLE);



	/* check to see PCF is really idled and we can access status register */

	if ((temp = get_pcf(adap, 1)) != (I2C_PCF_PIN | I2C_PCF_BB)) {

	temp = get_pcf(adap, 1);

	if (temp != (I2C_PCF_PIN | I2C_PCF_BB))

		return -ENXIO;

	}



	printk(KERN_DEBUG "i2c-algo-pcf.o: detected and initialized PCF8584.\n");
@@ -218,7 +218,8 @@ static int pcf_readbytes(struct i2c_adapter *i2c_adap, char *buf, 
	/* increment number of bytes to read by one -- read dummy byte */

	for (i = 0; i <= count; i++) {



		if ((wfp = wait_for_pin(adap, &status))) {

		wfp = wait_for_pin(adap, &status);

		if (wfp) {

			if (wfp == -EINTR)

				return -EINTR; /* arbitration lost */
@@ -351,7 +352,8 @@ int i2c_pcf_add_bus(struct i2c_adapter *adap) 
	/* register new adapter to i2c module... */

	adap->algo = &pcf_algo;



	if ((rval = pcf_init_8584(pcf_adap)))

	rval = pcf_init_8584(pcf_adap);

	if (rval)

		return rval;



	rval = i2c_add_adapter(adap);