Commit 2e922956 authored by Gabriel Shahrouzi's avatar Gabriel Shahrouzi Committed by Jonathan Cameron
Browse files

staging: iio: adc: ad7816: Correct conditional logic for store mode 



The mode setting logic in ad7816_store_mode was reversed due to
incorrect handling of the strcmp return value. strcmp returns 0 on
match, so the `if (strcmp(buf, "full"))` block executed when the
input was not "full".

This resulted in "full" setting the mode to AD7816_PD (power-down) and
other inputs setting it to AD7816_FULL.

Fix this by checking it against 0 to correctly check for "full" and
"power-down", mapping them to AD7816_FULL and AD7816_PD respectively.

Fixes: 7924425d ("staging: iio: adc: new driver for AD7816 devices")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGabriel Shahrouzi <gshahrouzi@gmail.com>
Acked-by: default avatarNuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/stable/20250414152920.467505-1-gshahrouzi%40gmail.com
Link: https://patch.msgid.link/20250414154050.469482-1-gshahrouzi@gmail.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 52d34988

drivers/staging/iio/adc/ad7816.c

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static ssize_t ad7816_store_mode(struct device *dev, 
	struct iio_dev *indio_dev = dev_to_iio_dev(dev);

	struct ad7816_chip_info *chip = iio_priv(indio_dev);



	if (strcmp(buf, "full")) {

	if (strcmp(buf, "full") == 0) {

		gpiod_set_value(chip->rdwr_pin, 1);

		chip->mode = AD7816_FULL;

	} else {