Commit 2eea791a authored by Kees Cook's avatar Kees Cook Committed by Jakub Kicinski
Browse files

pds_core: Allocate pdsc_viftype_defaults copy with ARRAY_SIZE() 



In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

This is allocating a copy of pdsc_viftype_defaults, which is an array of
struct pdsc_viftype. To correctly return "struct pdsc_viftype *" in the
future, adjust the allocation to allocating ARRAY_SIZE-many entries. The
resulting allocation size is the same.

Signed-off-by: default avatarKees Cook <kees@kernel.org>
Reviewed-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Link: https://patch.msgid.link/20250426060712.work.575-kees@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fca6170f

drivers/net/ethernet/amd/pds_core/core.c

+2 −1
Original line number Diff line number Diff line
@@ -414,7 +414,8 @@ static int pdsc_viftypes_init(struct pdsc *pdsc) 
{

	enum pds_core_vif_types vt;



	pdsc->viftype_status = kzalloc(sizeof(pdsc_viftype_defaults),

	pdsc->viftype_status = kcalloc(ARRAY_SIZE(pdsc_viftype_defaults),

				       sizeof(*pdsc->viftype_status),

				       GFP_KERNEL);

	if (!pdsc->viftype_status)

		return -ENOMEM;