Commit 2f05bff2 authored by Rob Herring's avatar Rob Herring Committed by Miquel Raynal
Browse files

dt-bindings: mtd: fixed-partitions: Fix 'sercomm,scpart-id' schema 



The schema for 'sercomm,scpart-id' is broken. The 'if' condition is
never true because 'compatible' is in the parent node, not the child
node the sub-schema applies to. The example passes as there are no
constraints on additional/unevaluated properties. That's a secondary
issue which is complicated due to nested partitions.

Drop the if/then schema and the unnecessary 'allOf' so that the
'sercomm,scpart-id' property is at least defined.

Cc: Mikhail Zhilkin <csharper2005@gmail.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20221111212824.4103514-1-robh@kernel.org
parent 74f4d797

Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml

+11 −18
Original line number Diff line number Diff line
@@ -31,23 +31,16 @@ properties: 


patternProperties:

  "@[0-9a-f]+$":

    allOf:

      - $ref: "partition.yaml#"

      - if:

          properties:

            compatible:

              contains:

                const: sercomm,sc-partitions

        then:

    $ref: partition.yaml#



    properties:

      sercomm,scpart-id:

              description: Partition id in Sercomm partition map. Mtd

                parser uses this id to find a record in the partition map

                containing offset and size of the current partition. The

                values from partition map overrides partition offset and

                size defined in reg property of the dts. Frequently these

                values are the same, but may differ if device has bad

                eraseblocks on a flash.

        description: Partition id in Sercomm partition map. Mtd parser

          uses this id to find a record in the partition map containing

          offset and size of the current partition. The values from

          partition map overrides partition offset and size defined in

          reg property of the dts. Frequently these values are the same,

          but may differ if device has bad eraseblocks on a flash.

        $ref: /schemas/types.yaml#/definitions/uint32



required: