Commit 2f076ea8 authored by Ryno Swart's avatar Ryno Swart Committed by Jakub Kicinski
Browse files

nfp: devlink: add extended ack report messages 



Add descriptive error messages to common devlink failures to
be more user friendly.

Signed-off-by: default avatarRyno Swart <ryno.swart@corigine.com>
Signed-off-by: default avatarLouis Peens <louis.peens@corigine.com>
Link: https://lore.kernel.org/r/20231206151209.20296-3-louis.peens@corigine.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b0318e28

drivers/net/ethernet/netronome/nfp/nfp_devlink.c

+6 −2
Original line number Diff line number Diff line
@@ -75,8 +75,10 @@ nfp_devlink_port_split(struct devlink *devlink, struct devlink_port *port, 
	if (ret)

		return ret;



	if (eth_port.port_lanes % count)

	if (eth_port.port_lanes % count) {

		NL_SET_ERR_MSG_MOD(extack, "invalid count");

		return -EINVAL;

	}



	/* Special case the 100G CXP -> 2x40G split */

	lanes = eth_port.port_lanes / count;
@@ -101,8 +103,10 @@ nfp_devlink_port_unsplit(struct devlink *devlink, struct devlink_port *port, 
	if (ret)

		return ret;



	if (!eth_port.is_split)

	if (!eth_port.is_split) {

		NL_SET_ERR_MSG_MOD(extack, "port is not split");

		return -EINVAL;

	}



	/* Special case the 100G CXP -> 2x40G unsplit */

	lanes = eth_port.port_lanes;